Fix modutils._is_subpath to handle base with trailing os.sep#2928
Merged
DanielNoord merged 2 commits intopylint-dev:mainfrom Jan 10, 2026
Merged
Fix modutils._is_subpath to handle base with trailing os.sep#2928DanielNoord merged 2 commits intopylint-dev:mainfrom
DanielNoord merged 2 commits intopylint-dev:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2928 +/- ##
=======================================
Coverage 93.41% 93.41%
=======================================
Files 92 92
Lines 11237 11237
=======================================
Hits 10497 10497
Misses 740 740
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
In case anyone else is impacted by this issue and needs a quick fix, here's what I'm doing: |
DanielNoord
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Currently on Windows if PATH contains a UNC path like
r"\\Mac\Code\"with a trailing slash, modutils.modpath_from_file won't be able to locate .py files liker"\\Mac\Code\tests\test_resources.py"inside such a path. Consequently, astroid will refuse to load the source code for .py files in such locations.This change fixes the underlying modutils._is_subpath function used by modutils.modpath_from_file to handle paths with trailing os.sep correctly.
I would have preferred to update the ModPathFromFileTest test suite rather than creating a new IsSubpathTest suite, but ModPathFromFileTest is currently not passing on Windows.